non-archival relay #827
Merged
non-archival relay #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
commented
Nov 22, 2024
| @@ -1155,6 +1155,7 @@ func (bgs *BGS) handleRepoTombstone(ctx context.Context, pds *models.PDS, evt *a | |||
| }).Error; err != nil { | |||
| return err | |||
| } | |||
| u.SetTombstoned(true) | |||
There was a problem hiding this comment.
this is an irrelevant fix of some other thing
whyrusleeping
force-pushed
the
feat/non-archive
branch
from
6c226ff to
ea68bde
Compare
brianolson
reviewed
Dec 6, 2024
pds/server.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| /* |
There was a problem hiding this comment.
if the dead code stays, leave a TODO about how we might bring it back and what for?
| @@ -54,12 +54,19 @@ func BenchmarkRepoMgrCreates(b *testing.B) { | |||
| b.Fatal(err) | |||
| } | |||
|
|
|||
| cs, err := carstore.NewCarStore(cardb, []string{cspath}) | |||
| /* | |||
There was a problem hiding this comment.
// TODO: refactor benchmark into core function which takes a carstore factory and make two benchmarks for standard file carstore and non-archival carstore
| @@ -69,7 +69,7 @@ func TestLoadNewRepo(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func testCarstore(t *testing.T, dir string) carstore.CarStore { | |||
| func testCarstore(t *testing.T, dir string, archive bool) carstore.CarStore { | |||
There was a problem hiding this comment.
add TODO comment about making some tests with archive=false ?
| @@ -606,7 +606,11 @@ func (ds *DeltaSession) CloseWithRoot(ctx context.Context, root cid.Cid, rev str | |||
| case *FileCarStore: | |||
| return ocs.writeNewShard(ctx, root, rev, ds.user, ds.seq, ds.blks, ds.rmcids) | |||
| case *NonArchivalCarstore: | |||
| return nil, ocs.updateLastCommit(ctx, ds.user, rev, root) | |||
| slice, err := blocksToCar(ctx, root, rev, ds.blks) | |||
There was a problem hiding this comment.
case on type should probably be a new interface method that both implement
|
Fixed the lint error over at #876 |
|
Thanks @audreyt ! |
fixes "struct literal uses unkeyed fields" in lint.
whyrusleeping
force-pushed
the
feat/non-archive
branch
from
9e70c2c to
51af58f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
real jank right now, but doesnt keep all the repo data, just does basic event validation